Skip to content

Conversation

@shmansa
Copy link
Contributor

@shmansa shmansa commented Apr 12, 2023

Added ESLint for react frontend. Removed ESLint from root directory as there were plugin issues.

To check lint cd PantryNodeReact && npm run lint

@shmansa shmansa requested review from reembot and skrlett April 12, 2023 02:15
Base automatically changed from frontend to main April 12, 2023 05:01
@AbhinavReddy-Dev AbhinavReddy-Dev changed the base branch from main to frontend April 12, 2023 06:16
Copy link
Contributor

@reembot reembot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not run for me locally for the linter.

@skrlett
Copy link
Contributor

skrlett commented Apr 12, 2023

This does not run for me locally for the linter.

try
npm install
to install the packages from the updated package manager and try to run the linter.

image

Apart from warning on react version in the linter, I don't see any problem.

Copy link
Contributor

@reembot reembot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@skrlett skrlett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@skrlett skrlett merged commit 8e6920c into frontend Apr 12, 2023
@skrlett skrlett deleted the frontend_linter branch April 12, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants