Add riscv64 info and simplify macos #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmmarslender
previously approved these changes
Sep 7, 2023
Co-authored-by: Chris Marslender <chrismarslender@gmail.com>
|
BTW: As a person not as conversant in docker as I'd like to be - there may be a better riscv64/debian image and/or it might make more sense for us to cache one that has more python and build tools - but also don't want to make any more work than this fun side project. |
cmmarslender
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify macos checks by just using CMAKE_SYSTME_PROCESSOR and add in riscv64