Skip to content

Set the correct commit author for mozilla cert workflow #19896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

Starttoaster
Copy link
Contributor

@Starttoaster Starttoaster commented Aug 5, 2025

Purpose:

To fix the mozilla ca cert update job.

Current Behavior:

When this workflow runs, the job logs output:

  remote: error: GH006: Protected branch update failed for refs/heads/update-cacert-pem.        
  remote: 
  remote: - Commits must have verified signatures.        
  remote:   Found 1 violation:        
  remote: 
  remote:   8edbcbe300a40af469074bbda694d670b74538ee        
  To https://github.com/Chia-Network/chia-blockchain
   ! [remote rejected] update-cacert-pem -> update-cacert-pem (protected branch hook declined)

This is likely because the commit author isn't being set correctly. The job logs also show the incorrect commit author for the gpg creds supplied to it.

New Behavior:

I believe this will just fix that.

In addition, I set the base and delete-branch fields just to define some newly undefined behavior. And updated the create-pull-request Action to the version it used to be because it was downgraded for some reason.

Testing Notes:

I just looked at some of the differences between the old workflow:

committer: "ChiaAutomation <automation@chia.net>"

And the new one: https://github.com/Chia-Network/chia-blockchain/blob/main/.github/workflows/update-mozilla-ca-cert.yaml#L34

And applied the changes that are relevant to this job using the incorrect commit author.

@Starttoaster Starttoaster requested a review from a team as a code owner August 5, 2025 18:10
@Starttoaster Starttoaster added CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Aug 5, 2025
@aqk aqk added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 5, 2025
@Starttoaster Starttoaster merged commit 4dfa474 into main Aug 5, 2025
525 of 535 checks passed
@Starttoaster Starttoaster deleted the starttoaster/update-mozilla branch August 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants