Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize missing hashes lookup. #19126

Open
wants to merge 4 commits into
base: long_lived/datalayer_merkle_blob
Choose a base branch
from

Conversation

fchirica
Copy link
Contributor

@fchirica fchirica commented Jan 13, 2025

Reduces the amount of SQL queries, by batching multiple required hashes from the delta file together.

Previous time to sync a medium store was 6 min 52 s, this change reduced the time to 6 min 43s.

@fchirica fchirica requested a review from a team as a code owner January 13, 2025 09:01
@fchirica fchirica added DataLayer Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jan 13, 2025
chia/data_layer/data_store.py Outdated Show resolved Hide resolved
chia/data_layer/data_store.py Outdated Show resolved Hide resolved
arvidn
arvidn previously approved these changes Jan 13, 2025
Copy link
Contributor

File Coverage Missing Lines
chia/data_layer/data_store.py 88.9% lines 257, 262
Total Missing Coverage
18 lines 2 lines 88%

Copy link

Pull Request Test Coverage Report for Build 12746785015

Details

  • 17 of 19 (89.47%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.003%) to 91.5%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/data_layer/data_store.py 17 19 89.47%
Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/wallet/util/wallet_sync_utils.py 1 85.64%
chia/plotters/plotters.py 1 90.94%
chia/_tests/core/util/test_lockfile.py 2 90.28%
chia/server/server.py 4 81.94%
chia/wallet/wallet_node.py 4 87.89%
chia/full_node/full_node.py 4 86.92%
chia/plotters/madmax.py 6 44.58%
chia/daemon/server.py 7 83.46%
Totals Coverage Status
Change from base Build 12713949865: 0.003%
Covered Lines: 105482
Relevant Lines: 115093

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog DataLayer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants