Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some checks when trying to join the same pool already joined #18822

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Nov 5, 2024

WIP...

Fixes #7292

@emlowe emlowe added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 5, 2024
@emlowe emlowe closed this Nov 5, 2024
@emlowe emlowe reopened this Nov 5, 2024
Copy link

coveralls-official bot commented Nov 6, 2024

Pull Request Test Coverage Report for Build 11716290246

Details

  • 64 of 69 (92.75%) changed or added relevant lines in 4 files are covered.
  • 39 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.962%

Changes Missing Coverage Covered Lines Changed/Added Lines %
chia/cmds/plotnft_funcs.py 7 12 58.33%
Files with Coverage Reduction New Missed Lines %
chia/full_node/pending_tx_cache.py 1 96.55%
chia/cmds/plotnft_funcs.py 1 17.52%
chia/wallet/util/wallet_sync_utils.py 1 86.07%
chia/wallet/wallet_node.py 4 88.18%
chia/full_node/weight_proof.py 4 90.48%
chia/server/ws_connection.py 4 88.1%
chia/server/address_manager.py 5 90.48%
chia/full_node/full_node.py 7 85.9%
chia/server/node_discovery.py 12 79.45%
Totals Coverage Status
Change from base Build 11710907999: 0.03%
Covered Lines: 102969
Relevant Lines: 112961

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Nov 7, 2024

File Coverage Missing Lines
chia/cmds/plotnft_funcs.py 58.3% lines 78, 223, 368, 379, 398
Total Missing Coverage
69 lines 5 lines 92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog coverage-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Unfriendly error message when joining pool already joined: "'NoneType' object is not iterable".
1 participant