Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable keyring for poetry #18342

Merged
merged 2 commits into from
Jul 22, 2024
Merged

disable keyring for poetry #18342

merged 2 commits into from
Jul 22, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jul 19, 2024 •
edited
Loading

testing to see what happens to left wakas like < and right wakas like >

Purpose:

python-poetry/poetry#8623

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky requested a review from a team as a code owner July 19, 2024 21:47
@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jul 19, 2024
@emlowe
Copy link
Contributor

emlowe commented Jul 19, 2024

Confirmed this is working for me on my repro system

hoffmang9
hoffmang9 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worked on my Pi4 which previously had the issue.

@Starttoaster Starttoaster merged commit 4003f39 into main Jul 22, 2024
374 checks passed
@Starttoaster Starttoaster deleted the disable_keyring_for_poetry branch July 22, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@altendky @emlowe @hoffmang9 @Starttoaster