CHIA-590: Add in connect timeout to DL http download #18339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emlowe
added
the
Added
altendky
requested changes
Jul 22, 2024
altendky
previously approved these changes
Jul 23, 2024
altendky
approved these changes
Jul 23, 2024
wjblanke
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adjustments to timeouts when datalayer is downloading files over HTTP.
The default total timeout is increased to 45s - this could probably be increased further since generally you really want to get the file fully downloaded
A new "socket connect" timeout is added and set to 5s. This means that the socket much connect within 5s - this helps with servers that are blackholing requests behind a firewall (incorrectly configured or down)
I am not sure how to test the socket connect timeout in CI since I doubt it's easy to force a connect timeout (note if the server isn't listening you will get an error immediately)