refactor: source file #121
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
this looks pretty reasonable at first glance. let me think about it a bit more. note that use of the word "submodule" to describe the different files might be a little confusing since they are not actually modules. |
samtkaplan
requested review from
JayMcIrish173,
gxingcvx,
jkwashbourne-oss and
nmbader
Member
|
I think too many small files ... maybe there is a happy medium somewhere between 1 and 10? |
Member
suggestion: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restructure the source code. I don't want take credit for the code, so I added you a co-author. Normally, this should give you credit in the commit history
Co-authored-by: samtkaplan sam.kaplan@chevron.com