Skip to content

Conversation

@MarshuMax
Copy link

Fixes #245

@eeee0717 eeee0717 self-requested a review December 31, 2025 03:01
@MarshuMax MarshuMax force-pushed the main branch 2 times, most recently from 316352f to c04e1b7 Compare January 2, 2026 07:21
@MarshuMax
Copy link
Author

MarshuMax commented Jan 2, 2026

Hi Experts,

I’d like to provide some context that may help save you time when reviewing my code. When fixing this issue, I considered several options:

Option 1: Use a fixed value of 100
In my testing, this value worked well. It wasn't too large or too small, and the display effect was great.
1767345086854_d

Option 2: Use HEADER_HEIGHT + TAB_BAR_HEIGHT
This is simply because both of these are heights of top components. However, logically, there is no causal relationship between using them to calculate the bottom padding. It would avoid defining a new variable and the values are quite close to each other.

Option 3: Dynamically calculate (measure the list item height)
This solution seems to be the best. However, the current module list's height is determined by the content, and there is no fixed height constant. If we use onLayout for dynamic measurement, the padding would initially be 0 during the first render, which could lead to flickering. This seems like quite a bit of work and would introduce some uncertainty, so I don't think this approach is worth it. Perhaps in the future, more experienced developers may consider it.

Given all these considerations, I opted for Option 1, which I think strikes the right balance.

Let me know if you have any thoughts or suggestions!

BR,
Marshu

@eeee0717
Copy link
Collaborator

eeee0717 commented Jan 2, 2026

#252
In fact, fixed values should not be used for processing. I adjusted the model sheet, and currently this effect can solve the problem while keeping consistency on both iOS and Android sides.

@eeee0717
Copy link
Collaborator

eeee0717 commented Jan 3, 2026

I will close this pr

@eeee0717 eeee0717 closed this Jan 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: 模型列表滑到底部最后一项显示不全(被裁切只剩半个)

2 participants