fix: make vllm --version work
#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidxia
commented
Apr 22, 2025
Comment on lines
+294
to
+296
| if isinstance(cls, type): | ||
| return cls.__module__ != "builtins" | ||
| return True |
|
@davidxia Great job on this—thanks a lot! |
|
@Chen-0210 thanks for merging. I forgot to sign off on the commit. If you give me write access to your fork, I can amend my commit. Maybe also fix the conflicts if you'd like. |
Sure, I’ve sent you an invitation. With the latest update, speed may have improved. Could you update your test to reflect the changes? |
|
Thanks so much. Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.