Rework luacontroller memory, disk #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should result in less overall computation in editor and main sandbox. But unfortunately, without luajit optimizations this doesn't work. (see next commits) extras: - modified the basic editor to use the new API. - added some quality of life extras to basic editor. - updated help page about memory, disk and links.
Notably, these functions also 'escapes' from libox's time tracking. This might be dangerous, but it's unlikely to cause problems... (famous words i'm sure)
Contributor
please don't do this, it feels pointless |
TheEt1234
reviewed
Apr 22, 2025
TheEt1234
reviewed
Apr 22, 2025
TheEt1234
reviewed
Apr 22, 2025
TheEt1234
reviewed
Apr 22, 2025
mods/sbz_logic/env.lua
Outdated
| return libf(function(...) | ||
| local hook = {debug.gethook()} | ||
| debug.sethook() | ||
| jit.on(true, true) |
Contributor
There was a problem hiding this comment.
ok so apparently you can do jit.on(func, true) instead, i think that's a better solution
jit.off also flushes away any optimizations
- Fix serializer not working for tables - Have write_disk() report bad disk data
Back to using libf/sandbox_lib_f
corpserot
changed the title
Contributor
|
is this merge-able or are you still working on it |
Contributor
Author
|
oh i forgot to say that. it's ready for merge/review. |
Contributor
|
hmm i should review this |
TheEt1234
reviewed
May 2, 2025
Contributor
TheEt1234
left a comment
TheEt1234
left a comment
There was a problem hiding this comment.
LGTM just needs a few changes
- sbz now (primarily) uses LuaJIT - luacontroller read_disk() and write_disk() now checks for NaN - typo fix
- don't escape terminal_text twice when rendering formspec - initialize mem.current_tab when punching editor
corpserot
commented
May 3, 2025
Contributor
Author
|
ready to merge |
Contributor
|
ok, @ChefZander you should merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the current implementation, the luacontroller memory and disk is read and write on every event. This is a problem because it's rather expensive and users cannot control how it's used. More often than not, nothing actually changed to these things during an event.
Proposed solution
(credit to frog for the idea) Instead of automagically having
memanddisksvariables be read-write in each event, instead that responsibility is passed to the user through these functions:read_mem()andwrite_mem()read_disk(),write_disk(),available_disks()andavailable_disk_names()For people that truly need speed, evenlinkswas reworked intoread_links().Because of the breaking change, the editor had to be adapted too. I've added some extra quality of life things and fixes. Most of the changes are in the
disktab.TODO
additionally. carefully enable JIT optimization (and disable time checking) in parts of the built-in functions.