Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KICS Reloaded POC #6493

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

KICS Reloaded POC #6493

wants to merge 1 commit into from

Conversation

pereiramarco011
Copy link
Contributor

Proposed Changes

  • Addition of flag to save parsing results
  • Addition of path protocol to read a previsouly saved parse result and skip parsing stage
  • Fix small bug where if line 1 is comment results whose line isnt found are ignored
  • Fix visual progress circle when scanning

I submit this contribution under the Apache-2.0 license.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

kics-logo

KICS version: v1.7.0

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 1
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 3, 2023
View reviewed changes
pkg/scan/scan.go
if err != nil {
return err
}
file, err := os.Create(reloadedPath)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
pkg/scan/scan.go

if usingReloaded {
kicsReloadedPath := strings.Split(c.ScanParams.Path[0], "kics-reloaded::")[1]
reloadedFileContent, err := os.ReadFile(kicsReloadedPath)

Check failure

Code scanning / gosec

Potential file inclusion via variable

Potential file inclusion via variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pereiramarco011