sca-container to sca, sarif severity and triage error codes#376
Merged
tiagobcx merged 10 commits intoApr 1, 2022
Conversation
… error code for triage
tiagobcx
requested review from
a team,
AndreGCX and
tsunez
and removed request for
a team
March 28, 2022 16:07
AndreGCX
previously approved these changes
Mar 28, 2022
cx-pedro-lopes
requested review from
a team
and removed request for
a team,
AndreGCX and
tsunez
March 31, 2022 08:43
ghost
previously approved these changes
Mar 31, 2022
ghost
self-requested a review
March 31, 2022 14:48
ghost
previously approved these changes
Mar 31, 2022
| } | ||
|
|
||
| if s.Type == "dependency" { | ||
| if s.Type == "dependency" || s.Type == "sca-container" { |
Contributor
There was a problem hiding this comment.
Can we do here startsWith ?
Contributor
Author
There was a problem hiding this comment.
Yes, in all cases or just for sca-container?
cx-pedro-lopes
approved these changes
Apr 1, 2022
ghost
approved these changes
Apr 1, 2022
tiagobcx
deleted the
feature/AST-1181-new-result-type-sarif-fix-error-codes
branch
April 1, 2022 13:29
thtri
referenced
this pull request
in thtri/ast-cli
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mapping sca-container type to sca in results;
Fixing missing severity map between Checkmarx and sarif format;
Handling new error codes for the triage commands.
References
https://checkmarx.atlassian.net/browse/AST-11081
https://checkmarx.atlassian.net/browse/AST-11130
https://checkmarx.atlassian.net/browse/AST-8903
Testing
Checklist