Removed validate() method to allow the use of EnvVars for the plugins.#133
Merged
2 commits merged intomainfrom Jul 4, 2022
Merged
Removed validate() method to allow the use of EnvVars for the plugins.#1332 commits merged intomainfrom
2 commits merged intomainfrom
Conversation
cx-pedro-lopes
requested review from
a team,
jay-nanduri and
tiagobcx
and removed request for
a team
Contributor
|
No New Or Fixed Issues Found |
ghost
enabled auto-merge (squash)
diogopcx
approved these changes
Jul 4, 2022
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate() method restricted the blank values for base url, apikey , client-id and client-secret. This caused a problem in the plugins when Envvars were used to store the client-id and client secret.