Skip to content

[25.05.05 / TASK-182] Feature - middleware 인가 로직 전체 리펙토링, 그에 따른 대응 개발 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 7, 2025
Merged

[25.05.05 / TASK-182] Feature - middleware 인가 로직 전체 리펙토링, 그에 따른 대응 개발 #30

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89b29ca
feature: 인가 미들 웨어 분리, 인증 로직은 서비스로 합병, 그에 따른 타입을 포함한 전체 리펙토링
Nuung May 4, 2025
8650263
feature: 미들웨어 자체 테스트 코드 추가, 그에 따른 velog api 유닛 테스트 추가
Nuung May 4, 2025
60a4446
modify: 검증 완료
Nuung May 4, 2025
4a37b62
modify: user me api 에서 username 때문에 외부 API 호출부분 추가
Nuung May 4, 2025
e6a1881
modify: SLACK_WEBHOOK_URL 이 왜 빠졌지? 추가
Nuung May 4, 2025
1052e20
modify: 테스트 코드 피드백 반영, 리펙토링 (가독성, 가시성)
Nuung May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
modify: user me api 에서 username 때문에 외부 API 호출부분 추가
  • Loading branch information
@Nuung
Nuung committed May 4, 2025
commit 4a37b629f7bcfc78e3222ad16ce0d16dc938786d
8 changes: 5 additions & 3 deletions src/controllers/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,15 @@ export class UserController {
res.status(200).json(response);
};

fetchCurrentUser: RequestHandler = (req: Request, res: Response<LoginResponseDto>) => {
const { user } = req;
fetchCurrentUser: RequestHandler = async (req: Request, res: Response<LoginResponseDto>) => {
// 외부 API (velog) 호출로 username 을 가져와야 함, 게시글 바로가기 때문에 (username)
const { accessToken, refreshToken } = req.tokens;
const velogUser = await fetchVelogApi(accessToken, refreshToken);

const response = new LoginResponseDto(
true,
'유저 정보 조회에 성공하였습니다.',
{ id: user.id, username: user.username, profile: user.profile },
{ id: req.user.id, username: velogUser.username, profile: velogUser.profile },
null,
);

Expand Down
Loading