Skip to content

Conversation

Nuung
Copy link
Member

@Nuung Nuung commented Mar 13, 2025

  • API 쪽 라우팅 / 컨트롤러 / 서비스 / 모델(레포) / 타입 모두 삭제
  • 참고로 back-office 대응 역시 필요

Summary by CodeRabbit

  • Chores
    • 사용자 행동 및 체류 시간 기록 기능이 제거되었습니다.
      → 기존 사용자 활동 추적을 위한 API 엔드포인트 및 데이터 처리 로직이 정리되어, 시스템이 더 간결해지고 유지보수가 용이해졌습니다.

이번 업데이트로 인해 사용자 트래킹 관련 데이터 수집이 중단되며, 전반적인 시스템 성능과 안정성이 향상될 것으로 기대됩니다.

@Nuung Nuung added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 13, 2025
@Nuung Nuung self-assigned this Mar 13, 2025
Copy link

Copy link
Contributor

coderabbitai bot commented Mar 13, 2025

Walkthrough

이 PR은 사용자 이벤트 및 머문 시간 추적과 관련된 기능을 전면 삭제하는 변경 사항입니다. 기존의 TrackingController, TrackingService, TrackingRepository, 그리고 관련 라우터와 DTO 및 타입 정의가 제거되었습니다. 또한, 트래킹 관련 라우팅 설정도 삭제되어 해당 API 엔드포인트가 더 이상 사용되지 않습니다. 전체적으로 기존 트래킹 로직과 연관 데이터 타입이 삭제됨에 따라 관련 기능이 제거됩니다.

Changes

파일 변경 요약
src/controllers/tracking.controller.ts, src/services/tracking.service.ts, src/repositories/tracking.repository.ts, src/routes/tracking.router.ts, src/routes/index.ts 트래킹 관련 컨트롤러, 서비스, 리포지토리 및 라우터와 라우팅 설정 삭제
src/types/dto/requests/eventRequest.type.ts, src/types/dto/requests/stayTimeRequest.dto.ts, src/types/index.ts 사용자 이벤트 및 머문 시간 관련 DTO, enum, 타입 export 삭제
src/types/models/PageVisits.type.ts, src/types/models/UserEventTracking.type.ts, src/types/userEvent.type.ts 페이지 방문 및 사용자 이벤트 추적 관련 인터페이스와 enum 삭제

Sequence Diagram(s)

해당 변경 사항에는 새로운 기능이나 제어 흐름의 변경이 없어 시퀀스 다이어그램이 없습니다.

Possibly related PRs

Poem

난 작은 토끼, 코드 숲 속 깡충깡충,
트래킹 기능은 사라지고 잔잔한 바람 불어오네,
로그의 번잡함은 이제 안녕,
깔끔한 코드길 따라 내 발걸음 가볍네,
🐇 오늘도 새 희망 안고 뛰노는 내 마음,
변화의 노래 속에 즐거움 가득하네.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc1a377 and b428152.

📒 Files selected for processing (11)
  • src/controllers/tracking.controller.ts (0 hunks)
  • src/repositories/tracking.repository.ts (0 hunks)
  • src/routes/index.ts (0 hunks)
  • src/routes/tracking.router.ts (0 hunks)
  • src/services/tracking.service.ts (0 hunks)
  • src/types/dto/requests/eventRequest.type.ts (0 hunks)
  • src/types/dto/requests/stayTimeRequest.dto.ts (0 hunks)
  • src/types/index.ts (0 hunks)
  • src/types/models/PageVisits.type.ts (0 hunks)
  • src/types/models/UserEventTracking.type.ts (0 hunks)
  • src/types/userEvent.type.ts (0 hunks)
💤 Files with no reviewable changes (11)
  • src/types/userEvent.type.ts
  • src/types/models/UserEventTracking.type.ts
  • src/types/dto/requests/eventRequest.type.ts
  • src/types/dto/requests/stayTimeRequest.dto.ts
  • src/routes/tracking.router.ts
  • src/types/index.ts
  • src/controllers/tracking.controller.ts
  • src/services/tracking.service.ts
  • src/routes/index.ts
  • src/types/models/PageVisits.type.ts
  • src/repositories/tracking.repository.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

six-standard

This comment was marked as outdated.

@six-standard six-standard self-requested a review March 13, 2025 22:57
Copy link
Member

@six-standard six-standard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사실상 지우기만 하셔서 크게 리뷰드릴 내용이 없네요~

Copy link
Contributor

@Jihyun3478 Jihyun3478 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 삭제하신 부분 모두 확인했습니다~! 크게 이견 없습니다!

@Nuung Nuung merged commit 4a73e7f into main Mar 14, 2025
5 checks passed
@Nuung Nuung deleted the delete/event-tracking branch March 14, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants