Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复检查更新会提示有pre-release版本需要更新的问题 #6280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Coean
Copy link

@Coean Coean commented Feb 22, 2025

💻 变更类型 | Change Type

  • feat
  • fix
  • refactor
  • perf
  • style
  • test
  • docs
  • ci
  • chore
  • build

🔀 变更说明 | Description of Change

  • fix: use the latest release API to check the latest release version for excluding pre-release versions
image

📝 补充信息 | Additional Information

#6270

Summary by CodeRabbit

  • New Features

    • Enhanced version update detection now retrieves the most current release information, ensuring users access up-to-date release data.
  • Refactor

    • Streamlined the process for fetching release details to improve the accuracy and consistency of version displays.

Copy link

vercel bot commented Feb 22, 2025

Someone is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Feb 22, 2025

Walkthrough

This pull request updates the interaction with the GitHub API by replacing the endpoint for fetching tags with one for retrieving the latest release information. In app/constant.ts, the constant FETCH_TAG_URL is removed and replaced with FETCH_LATEST_RELEASE_URL. In app/store/update.ts, the API call is updated to use the new constant and the expected response structure is modified in the getVersion function to return data.tag_name. The overall control flow remains unchanged.

Changes

File(s) Change Summary
app/constant.ts, app/store/update.ts Renamed constant: FETCH_TAG_URL replaced with FETCH_LATEST_RELEASE_URL to change API endpoint.
app/store/update.ts Updated getVersion logic to process response with tag_name and name instead of the tag format.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Store
    participant GitHubAPI

    Client->>Store: Request version info (getVersion)
    Store->>GitHubAPI: GET FETCH_LATEST_RELEASE_URL
    GitHubAPI-->>Store: Returns release data (tag_name, name)
    Store-->>Client: Return version using tag_name
Loading

Poem

I’m a little rabbit, hopping with delight,
Chasing new releases through the code’s invite.
No more fetching old tags in the night,
Now with new constants, our future’s bright!
Hop on, code friends—let’s keep our bugs out of sight!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f5f3ce9 and 6888f10.

📒 Files selected for processing (2)
  • app/constant.ts (1 hunks)
  • app/store/update.ts (2 hunks)
🔇 Additional comments (3)
app/store/update.ts (2)

2-6: LGTM!

The import changes correctly reflect the switch from tag-based to release-based version checking.


44-48: LGTM!

The response type correctly matches GitHub's latest release API structure. This change will effectively filter out pre-release versions since the /latest endpoint only returns the latest full release.

app/constant.ts (1)

9-9: LGTM!

The new endpoint is a better choice for version checking as it:

  1. Returns only the latest full release
  2. Automatically excludes pre-releases
  3. Provides richer metadata about the release
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant