Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #4762

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ceddy4395
Copy link

Hey! 🙂
I've made the following changes to your workflow:

  • Avoid incorrectly indented workflows
    • Make sure that workflows are readable for other developers so that they can easily understand what the workflow is doing.
  • Prevent running issue/PR actions on forks
    • Running workflows that modify issues on forks will fail because they do not have access to the issues on the original repository.
  • Define permissions for workflows with external actions
    • Permissions should be used when running actions written by other developers because there may be security leaks exposed through these actions.
  • Use commit hash instead of tags for action versions
    • When using a tag as version, the code related to the tag can be changed after the tag is created, whereas when using the commit hash this cannot. Therefore, for consistency and security a commit hash should be used.

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

- Avoid incorrectly indented workflows
- Prevent running issue/PR actions on forks
- Define permissions for workflows with external actions
- Use commit hash instead of tags for action versions
Copy link

vercel bot commented May 22, 2024

@ceddy4395 is attempting to deploy a commit to the NextChat Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

Your build has completed!

Preview deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant