[Cloud Sync] #2854
Open
[Cloud Sync] #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[+] Add support for GithubGist synchronization in useSyncStore - Updated the `WebDavConfig` interface to include the `filename` property. - Added the `GistConfig` interface to define the filename, gistId, and token for GitHub Gist synchronization. - Modified the `createPersistStore` function in the `useSyncStore` module to include the `githubGist` and `upstash` properties in the initial state, with empty values for their respective properties. - Added the `lastUpdateTime` and `syncing` properties to the initial state to track the last update time and synchronization status. - Updated the `sync` method to handle the synchronization logic for WebDAV, including merging the remote state, updating the local state, and overwriting access control settings if specified. - Implemented the `markUpdateTime` method to update the last update time when performing synchronization. - Added the `countSync` method to check if all required configuration values for the selected provider are filled. - Modified the `export` method to generate a backup file name based on the current date and time. - Updated the `import` method to handle importing JSON files split into multiple chunks. - Updated the `sync` method to handle merging filtered topics and updating masks. - Added the necessary dependencies and ensured that the `createSyncClient` function in the `cloud` module accepts the required arguments for setting up the data. These changes extend the `useSyncStore` module to support synchronization with WebDAV in addition to GitHub Gist and Upstash. The module now provides methods to sync, export, import, and check synchronization state with the selected provider. The code also includes improvements for handling synchronization and merging state, as well as managing access control settings. [+] Fix locale language inconsistencies in `useSyncStore` - Updated the text strings in the `useSyncStore` module to ensure consistent and accurate locale language usage throughout the codebase.
|
Note
|
Note
|
|
Preview Github Gist Sync : |
Preview Github Gist Sync : |
- Fix 'client.set is not a function' error and update 'set' method to handle different value types - Introduce separate synchronization methods for WebDAV and GitHub Gist providers - Implement provider-specific synchronization logic in the 'sync' method - Update 'syncWebDAV' to correctly set data using 'client.set' with 'filename' and 'JSON.stringify(localState)' - Update 'syncGitHubGist' to properly set data using 'client.set' with 'localState' and 'value - Enhance 'set' method in 'SyncClient' to accept both 'Object' and 'string' as 'value' parameters - Ensure correct passing of 'localState' and 'value' in 'syncGitHubGist' method for GitHub Gist synchronization
3 tasks
H0llyW00dzZ
commented
Sep 18, 2023
|
additional note for an improvement webdav in this PR already added
after attempt fix by automated
|
[+] Update `check` method to use `PROPFIND` instead of `MKCOL` In the `webdav.ts` module, updated the `check` method to use the `PROPFIND` method instead of `MKCOL` to check if the file exists. This change was made to handle cases where the server does not allow the `MKCOL` method. The `PROPFIND` method is used to retrieve the properties of the file, and if the response status is either 200 (OK), 207 (Multi-Status), or 404 (Not Found), it considers the file to exist.
- fix(settings): remove unnecessary code for syncing with GitHub Gist provider - fix(sync): change console.error to console.log for failed remote state retrieval from file - fix(gist): simplify logic for checking if Gist exists or not
[+] feat(gist.ts): implement content chunking for gist creation
[+] fix(sync.ts): swap merge order in mergeWithUpdate function
[+] feat(route.ts): change runtime from nodejs to edge [+] refactor(sync.ts): extract default sync state to a constant [+] fix(sync.ts): correct accessControl properties assignment [+] feat(sync.ts): add migration function for version 1.1 to update upstash username
[+] fix(route.ts): set CORS headers for preflight requests in handle function [+] feat(route.ts): add support for Access-Control-Allow-Origin, Access-Control-Allow-Methods, Access-Control-Allow-Headers, and Access-Control-Max-Age headers in preflight requests
[+] feat(format.ts): add function to split a string into chunks based on byte size
[+] fix(gist.ts): fix indentation and remove unnecessary comments [+] chore(gist.ts): update console.log messages for better readability [+] fix(webdav.ts): update console.log messages for better readability
[+] refactor(settings.tsx): remove unnecessary code and reorganize CheckButton component logic
kkocdko
approved these changes
Dec 31, 2023
| @@ -150,7 +150,7 @@ export function mergeWithUpdate<T extends { lastUpdateTime?: number }>( | |||
| remoteState: T, | |||
| ) { | |||
| const localUpdateTime = localState.lastUpdateTime ?? 0; | |||
| const remoteUpdateTime = localState.lastUpdateTime ?? 1; | |||
| const remoteUpdateTime = remoteState.lastUpdateTime ?? 1; | |||
| }, | ||
|
|
||
| export() { | ||
| const state = getLocalAppState(); | ||
| const fileName = `Backup-${new Date().toLocaleString()}.json`; | ||
| downloadAs(JSON.stringify(state), fileName); | ||
| const fileName = `Backup-${new Date().toLocaleString()}`; |
There was a problem hiding this comment.
Is this change necessary? Can we just keep downloadAs receive string?
There was a problem hiding this comment.
Is this change necessary? Can we just keep
downloadAsreceive string?
that branch are outdated
a better one already implemented here:
export() {
const state = getLocalAppState();
const datePart = isApp
? `${new Date().toLocaleDateString().replace(/\//g, '_')} ${new Date().toLocaleTimeString().replace(/:/g, '_')}`
: new Date().toLocaleString();
const fileName = `Backup-${datePart}.json`;
downloadAs((state), fileName);
},
|
Is this PR outdated? Is there a new PR to fix the current cloud sync behavior? To be honest, the current cloud sync is quite poor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+] Add support for GithubGist synchronization in useSyncStore
WebDavConfiginterface to include thefilenameproperty.GistConfiginterface to define the filename, gistId, and token for GitHub Gist synchronization.createPersistStorefunction in theuseSyncStoremodule to include thegithubGistandupstashproperties in the initial state, with empty values for their respective properties.lastUpdateTimeandsyncingproperties to the initial state to track the last update time and synchronization status.syncmethod to handle the synchronization logic for WebDAV, including merging the remote state, updating the local state, and overwriting access control settings if specified.markUpdateTimemethod to update the last update time when performing synchronization.countSyncmethod to check if all required configuration values for the selected provider are filled.exportmethod to generate a backup file name based on the current date and time.importmethod to handle importing JSON files split into multiple chunks.syncmethod to handle merging filtered topics and updating masks.createSyncClientfunction in thecloudmodule accepts the required arguments for setting up the data.These changes extend the
useSyncStoremodule to support synchronization with WebDAV in addition to GitHub Gist and Upstash. The module now provides methods to sync, export, import, and check synchronization state with the selected provider. The code also includes improvements for handling synchronization and merging state, as well as managing access control settings.[+] Fix locale language inconsistencies in
useSyncStoreuseSyncStoremodule to ensure consistent and accurate locale language usage throughout the codebase.