-
Notifications
You must be signed in to change notification settings - Fork 822
crop text in middle instead of decimate it #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -28,11 +28,12 @@ const clamp = (v, min, max) => { | |||||
return Math.min(Math.max(v, min), max) | ||||||
} | ||||||
|
||||||
/** this function will crop text by keeping the beginning and end */ | ||||||
export async function cropText( | ||||||
text, | ||||||
maxLength = 4000, | ||||||
startLength = 400, | ||||||
endLength = 300, | ||||||
maxLength = 200000, | ||||||
startLength = 0, | ||||||
endLength = 0, | ||||||
tiktoken = true, | ||||||
) { | ||||||
const userConfig = await getUserConfig() | ||||||
|
@@ -41,54 +42,69 @@ export async function cropText( | |||||
null, | ||||||
userConfig.customModelName, | ||||||
).match(/[- (]*([0-9]+)k/)?.[1] | ||||||
|
||||||
// for maxlength prefer modelLimit > userLimit > default | ||||||
if (k) { | ||||||
// if we have the models exact content limit use that | ||||||
maxLength = Number(k) * 1000 | ||||||
maxLength -= 100 + clamp(userConfig.maxResponseTokenLength, 1, maxLength - 1000) | ||||||
} else if (userConfig.maxResponseTokenLength) { | ||||||
// if we don't have the models exact content limit use the default | ||||||
maxLength = userConfig.maxResponseTokenLength | ||||||
} else { | ||||||
maxLength -= 100 + clamp(userConfig.maxResponseTokenLength, 1, maxLength - 1000) | ||||||
// if we don't have the models exact content limit use the default | ||||||
} | ||||||
|
||||||
const splits = text.split(/[,,。??!!;;]/).map((s) => s.trim()) | ||||||
const splitsLength = splits.map((s) => (tiktoken ? encode(s).length : s.length)) | ||||||
const length = splitsLength.reduce((sum, length) => sum + length, 0) | ||||||
if (userConfig.maxResponseTokenLength) { | ||||||
maxLength = clamp(maxLength, 1, userConfig.maxResponseTokenLength) | ||||||
} | ||||||
maxLength -= 100 // give some buffer | ||||||
|
||||||
const cropLength = length - startLength - endLength | ||||||
const splits = text.split(/[,,。??!!;;\n]/).map((s) => s.trim()) | ||||||
const splitsLength = splits.map((s) => (tiktoken ? encode(s).length : s.length)) | ||||||
const cropTargetLength = maxLength - startLength - endLength | ||||||
const cropPercentage = cropTargetLength / cropLength | ||||||
const cropStep = Math.max(0, 1 / cropPercentage - 1) | ||||||
|
||||||
if (cropStep === 0) return text | ||||||
|
||||||
let firstHalfTokens = 0 | ||||||
let secondHalfTokens = 0 | ||||||
const halfTargetTokens = Math.floor(cropTargetLength / 2) | ||||||
let middleIndex = -1 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the input text is short and the first pass never exceeds the halfTargetTokens, middleIndex will remain -1, which may lead to unexpected slicing. Consider adding a condition to bypass cropping when the text length is within limits. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
let endStartIndex = splits.length | ||||||
let totalTokens = splitsLength.reduce((sum, length) => sum + length + 1, 0) | ||||||
let croppedTokens = 0 | ||||||
let croppedText = '' | ||||||
let currentLength = 0 | ||||||
let currentIndex = 0 | ||||||
let currentStep = 0 | ||||||
|
||||||
for (; currentIndex < splits.length; currentIndex++) { | ||||||
if (currentLength + splitsLength[currentIndex] + 1 <= startLength) { | ||||||
croppedText += splits[currentIndex] + ',' | ||||||
currentLength += splitsLength[currentIndex] + 1 | ||||||
} else if (currentLength + splitsLength[currentIndex] + 1 + endLength <= maxLength) { | ||||||
if (currentStep < cropStep) { | ||||||
currentStep++ | ||||||
} else { | ||||||
croppedText += splits[currentIndex] + ',' | ||||||
currentLength += splitsLength[currentIndex] + 1 | ||||||
currentStep = currentStep - cropStep | ||||||
} | ||||||
// First pass: find the middle | ||||||
for (let i = 0; i < splits.length; i++) { | ||||||
if (firstHalfTokens < halfTargetTokens) { | ||||||
firstHalfTokens += splitsLength[i] + 1 | ||||||
} else { | ||||||
middleIndex = i | ||||||
break | ||||||
} | ||||||
} | ||||||
|
||||||
let endPart = '' | ||||||
let endPartLength = 0 | ||||||
for (let i = splits.length - 1; endPartLength + splitsLength[i] <= endLength; i--) { | ||||||
endPart = splits[i] + ',' + endPart | ||||||
endPartLength += splitsLength[i] + 1 | ||||||
// Second pass: find the start of the end section | ||||||
for (let i = splits.length - 1; i >= middleIndex; i--) { | ||||||
secondHalfTokens += splitsLength[i] + 1 | ||||||
if (secondHalfTokens >= halfTargetTokens) { | ||||||
endStartIndex = i | ||||||
break | ||||||
} | ||||||
} | ||||||
currentLength += endPartLength | ||||||
croppedText += endPart | ||||||
|
||||||
// Calculate cropped tokens | ||||||
croppedTokens = totalTokens - firstHalfTokens - secondHalfTokens | ||||||
|
||||||
// Construct the cropped text | ||||||
croppedText = splits.slice(0, middleIndex).join('\n') | ||||||
if (croppedTokens > 0) { | ||||||
croppedText += `\n\n**Important disclaimer**, this text is incomplete! ${croppedTokens} or ${ | ||||||
(croppedTokens / totalTokens).toFixed(2) * 100 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nitpick] Consider explicitly converting the result of toFixed to a number (e.g., using Number(...)) to avoid any unexpected type coercion issues.
Suggested change
Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||||||
}% of tokens have been removed from this location in the text due to lack limited model context of ${maxLength}\n\n` | ||||||
} | ||||||
croppedText += splits.slice(endStartIndex).join('\n') | ||||||
|
||||||
currentLength = firstHalfTokens + secondHalfTokens + (middleIndex !== endStartIndex ? 20 : 0) // 20 is approx the length of the disclaimer | ||||||
|
||||||
console.log( | ||||||
`input maxLength: ${maxLength}\n` + | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So maybe the entire
else
block should be removed?