Skip to content

Always FetchContent#31

Merged
mirams merged 5 commits into
mainfrom
issue30_always_fetchcontent
Jul 6, 2023
Merged

Always FetchContent#31
mirams merged 5 commits into
mainfrom
issue30_always_fetchcontent

Conversation

@kwabenantim

@kwabenantim kwabenantim commented Jul 5, 2023

Copy link
Copy Markdown
Member

Fixes #30

@kwabenantim kwabenantim added the bug label Jul 5, 2023
@kwabenantim kwabenantim self-assigned this Jul 5, 2023
@kwabenantim kwabenantim marked this pull request as ready for review July 5, 2023 15:09
@kwabenantim

kwabenantim commented Jul 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Changes

  • Switched from CMake FetchContent to CMake file download for finer control over which files get downloaded and when.
  • Changed default cellml location from src/cellml/cellml to src/cellml.
  • Updated documentation references to FetchContent and src/cellml/cellml.

@kwabenantim kwabenantim requested a review from mirams July 5, 2023 15:26
@kwabenantim

kwabenantim commented Jul 5, 2023

Copy link
Copy Markdown
Member Author

Tests pass after:

cmake ..
rm -rf src/cellml
cmake ..

https://github.com/Chaste/ApPredict/actions/runs/5465920736/jobs/9950085663

@mirams mirams merged commit 2e5f956 into main Jul 6, 2023
@mirams mirams deleted the issue30_always_fetchcontent branch July 6, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirams mirams Awaiting requested review from mirams

Assignees

@kwabenantim kwabenantim

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Always fetch missing CellML files

2 participants

@kwabenantim @mirams