Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed no used warning #4841

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Conversation

eren-celik
Copy link
Contributor

@eren-celik eren-celik commented Jun 15, 2022

Issue Link πŸ”—

Goals ⚽

there will be no warning in demo project

Implementation Details 🚧

As I noticed in the demo project, it was giving a warning that the addEntryOrdered(_ e: ChartDataEntry) function is not used. That's why I made the development

Testing Details πŸ”

@pmairoldi pmairoldi self-assigned this Aug 27, 2022
Copy link
Collaborator

@pmairoldi pmairoldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just change the function to return void instead. I can't think of a case where we need to know if the result had been added successfully.

@pmairoldi pmairoldi added this to the 5.0.0 milestone Mar 11, 2023
@pmairoldi pmairoldi changed the base branch from master to release/5.0.0 March 21, 2023 02:34
@pmairoldi pmairoldi merged commit e392e19 into ChartsOrg:release/5.0.0 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants