53000 - gracefully manage ChartIQView destruction #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 20, 2025 14:38
…e-SDK into users/chirag.vora/53000-rn-crash
jdrichards50
requested changes
Aug 21, 2025
| import { StyleSheet, View, ViewStyle } from 'react-native'; | ||
| import { ChartIQ, ChartIQLanguages, ChartIQView } from 'react-native-chartiq'; | ||
| import { SafeAreaView } from 'react-native-safe-area-context'; | ||
| import { useNavigation, useRoute } from '@react-navigation/native'; |
Contributor
There was a problem hiding this comment.
This linter warning are starting to pile up, should we knock out these simple ones that suggest import order?
|
|
||
| const RootNavigator: React.FC = () => { | ||
| // Flag to start app in Test Rig screen | ||
| const shouldStartInTestRig = true; |
Contributor
There was a problem hiding this comment.
Let's go ahead and set this back to false, just in case we forget.
Contributor
Author
There was a problem hiding this comment.
Ops! Thanks for catching. I've mentioned it's false by default in PR description but missed to stage.
jdrichards50
approved these changes
Aug 21, 2025
Contributor
jdrichards50
left a comment
jdrichards50
left a comment
There was a problem hiding this comment.
Looks good, testrig also very helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://chartiq.kanbanize.com/ctrl_board/15/cards/53000/details/
RCA: App was crashing when users navigated away from the chart. The chart view got destroyed but async callbacks kept running with invalid references.
Solution: Added safety checks so callbacks gracefully handle destroyed views instead of crashing. Applied the fix to both iOS (where the issue was happening) and Android (as prevention).
Testing: Added a Test Rig screen with a
shouldStartInTestRigflag in root navigator (example/src/navigation/root.navigator.tsx). When set to true(defaults to false), app opens directly to Test Rig instead of main chart, making it easy to test navigation scenarios and validate the crash fix. You will see back button only if you are navigating from test-rig screen