Skip to content

Conversation

@chiragsp55
Copy link
Contributor

@chiragsp55 chiragsp55 commented Jul 4, 2025

Chirag Vora added 2 commits July 4, 2025 17:55
@chiragsp55
Copy link
Contributor Author

chiragsp55 commented Jul 4, 2025

@jdrichards50 Once you publish android SDK to maven, pls let me know, we need update line#80 @android/build.gradle

also in Fluttter app: line#38 android/build.gradle

Copy link
Contributor

@jdrichards50 jdrichards50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. I did find one issue with the drawing menu. Once you scroll down the menu header scrolls underneath the top of the phone. Once there it stays and you aren't able to click on the cancel button or the setting ellipses unless you scroll the menu all the way up again. Are we able to make this menu like the studies menu and keep the header static?

Screenshot 2025-07-07 at 9 05 49 PM

@jdrichards50
Copy link
Contributor

Maybe this is just my emulator, but I'm not able to scroll all the way down the chart types menu. Range Bars and PandF remains out of reach.

@chiragsp55
Copy link
Contributor Author

This is looking really good. I did find one issue with the drawing menu. Once you scroll down the menu header scrolls underneath the top of the phone. Once there it stays and you aren't able to click on the cancel button or the setting ellipses unless you scroll the menu all the way up again. Are we able to make this menu like the studies menu and keep the header static?

Screenshot 2025-07-07 at 9 05 49 PM

@jdrichards50 I've observed it but as it was existing issue and required major change, I left it aside.... Fixed now! Working as expected in android and ios

@chiragsp55
Copy link
Contributor Author

Maybe this is just my emulator, but I'm not able to scroll all the way down the chart types menu. Range Bars and PandF remains out of reach.

yeah, sometime it doesn't work in simulator... I've double checked, it's working fine

@chiragsp55
Copy link
Contributor Author

@jdrichards50 updated . As we did for ios cocoapods, using latest chartIQ SDK version always.

@jdrichards50 jdrichards50 merged commit 07657d2 into main Jul 10, 2025
2 checks passed
@jdrichards50 jdrichards50 deleted the users/chirag.vora/53975-ReactNativeIssue branch July 10, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants