33089 full project code review

.gitignore

@@ -1,23 +1,80 @@
-# Compiled class file
+# Built application files
+*.apk
+*.aar
+*.ap_
+*.aab
+
+# Files for the ART/Dalvik VM
+*.dex
+
+# Java class files
 *.class
 
-# Log file
+# Generated files
+bin/
+gen/
+out/
+#  Uncomment the following line in case you need and you don't have the release build type files in your app
+# release/
+
+# Gradle files
+.gradle/
+build/
+
+# Local configuration file (sdk path, etc)
+local.properties
+
+# Proguard folder generated by Eclipse
+proguard/
+
+# Log Files
 *.log
 
-# BlueJ files
-*.ctxt
+# Android Studio Navigation editor temp files
+.navigation/
+
+# Android Studio captures folder
+captures/
+
+# IntelliJ
+.idea/
+
+# Keystore files
+# Uncomment the following lines if you do not want to check your keystore files in.
+#*.jks
+#*.keystore
+
+# External native build folder generated in Android Studio 2.2 and later
+.externalNativeBuild
+.cxx/
+
+# Google Services (e.g. APIs or Firebase)
+# google-services.json
+
+# Freeline
+freeline.py
+freeline/
+freeline_project_description.json
+
+# fastlane
+fastlane/report.xml
+fastlane/Preview.html
+fastlane/screenshots
+fastlane/test_output
+fastlane/readme.md
+
+# Version control
+vcs.xml
 
-# Mobile Tools for Java (J2ME)
-.mtj.tmp/
+# lint
+lint/intermediates/
+lint/generated/
+lint/outputs/
+lint/tmp/
+# lint/reports/
 
-# Package Files #
-*.jar
-*.war
-*.nar
-*.ear
-*.zip
-*.tar.gz
-*.rar
+# Android Profiling
+*.hprof
 
-# virtual machine crash logs, see http://www.java.com/en/download/help/error_hotspot.xml
-hs_err_pid*
+# Android Studio
+.project

README.md

@@ -1 +1,63 @@
-# ChartIQ-Android-SDK
+# ChartIQ-Android-SDK
+
+Native Android SDK for the [ChartIQ JavaScript library](https://documentation.chartiq.com).
+
+<table>
+  <tr>
+    <td>:construction: <b>BETA Release</b>. Please visit us again starting March 31, 2021 to download the final release of this SDK and accompanying mobile application.</td>
+  </tr>
+</table>
+
+The ChartIQ Android SDK supports a basic charting application. The SDK can be extended to support more elaborate implementations by adding code to invoke ChartIQ library functions directly or by creating a bridge file similar to *nativeSdkBridge.js* (in the *mobile/js* folder of your ChartIQ library).
+
+Contact us at <support@chartiq.com> to request sample code and guidance on how to extend the SDK.
+
+## Requirements
+
+- Version 8.2.0 or later of the ChartIQ library
+
+  Go to our <a href="https://cosaic.io/chartiq-sdk-library-download/" target="_blank">download site</a> to obtain a free 30-day trial version of the library, or send us an email at <info@cosaic.io>, and we'll send you an evaluation version.
+
+- Android 8.1 Oreo (API level 27) or later
+
+## Sample app
+
+The [demo](https://github.com/ChartIQ/ChartIQ-Android-SDK/tree/main/demo) folder of this repository contains a sample app that was built using the SDK. Customize the app to quickly create your own Android charting application.
+
+The app is also available on Google Play.
+
+**App screen shots**
+
+<table>
+  <tr>
+    <td><img src="https://github.com/ChartIQ/ChartIQ-Android-SDK/blob/main/screenshots/Candle_Chart.png?raw=true" alt="Candle chart" width="200" height="440"/></td>
+    <td><img src="https://github.com/ChartIQ/ChartIQ-Android-SDK/blob/main/screenshots/Chart_with_Studies.png?raw=true" alt="Chart with studies" width="200" height="440"/></td>
+    <td><img src="https://github.com/ChartIQ/ChartIQ-Android-SDK/blob/main/screenshots/Chart_Styles_and_Types.png?raw=true" alt="Chart styles and types" width="200" height="440"/></td>
+  </tr>
+</table>
+
+**End of legacy app support**
+
+The Android app has been totally reengineered for improved usability and functionality using Kotlin. As a result, there is no upgrade path from the [legacy app](https://github.com/ChartIQ/Charting-Library---Android-Sample-App-Legacy) (which is compatible with ChartIQ versions 7.0.5&ndash;7.5.0) to the new app/SDK. To take advantage of the major improvements offered by the new mobile app, upgrade to Version 8.2.0 or later of the library and reimplement any custom functionality from your legacy app in the new app.
+
+## Getting started
+
+See the [Getting Started on Mobile: Android](https://documentation.chartiq.com/tutorial-Starting%20on%20Android.html) tutorial for instructions on installing the app and using the SDK.
+
+## Customization
+
+For information on changing the appearance of the app, see our [customization](https://documentation.chartiq.com/tutorial-Mobile%20App%20Customization%20Android.html) tutorial.
+
+## API documentation
+
+- [App/SDK](https://documentation.chartiq.com/android-sdk/chartiq/)
+
+- [ChartIQ JavaScript library](https://documentation.chartiq.com)
+
+## Questions and support
+
+Contact our development support team at <support@chartiq.com>.
+
+## Contributing to this project
+
+Contribute to this project. Fork it and send us a pull request. We'd love to see what you can do with our charting tools on Android!

build.gradle

@@ -0,0 +1,34 @@
+// Top-level build file where you can add configuration options common to all sub-projects/modules.
+buildscript {
+    ext.kotlin_version = '1.4.21'
+
+    repositories {
+        google()
+        jcenter()
+    }
+    dependencies {
+        classpath 'com.android.tools.build:gradle:4.1.2'
+        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+        classpath "org.jfrog.buildinfo:build-info-extractor-gradle:4.1.1"
+        classpath "androidx.navigation:navigation-safe-args-gradle-plugin:2.3.2"
+        classpath 'com.google.gms:google-services:4.3.4'
+        classpath 'com.google.firebase:firebase-crashlytics-gradle:2.4.1'
+        classpath("org.jetbrains.dokka:dokka-gradle-plugin:1.4.20")
+
+
+
+        // NOTE: Do not place your application dependencies here; they belong
+        // in the individual module build.gradle files
+    }
+}
+
+allprojects {
+    repositories {
+        google()
+        jcenter()
+    }
+}
+
+task clean(type: Delete) {
+    delete rootProject.buildDir
+}

chartiq/build.gradle

@@ -0,0 +1,69 @@
+apply plugin: 'com.android.library'
+apply plugin: 'kotlin-android'
+apply plugin: 'com.jfrog.artifactory'
+apply plugin: 'maven-publish'
+apply plugin: 'kotlin-android-extensions'
+apply plugin: 'org.jetbrains.dokka'
+
+
+ext.version_name = "4.0.0"
+
+dokkaHtml.configure {
+    dokkaSourceSets {
+        named("main") {
+            noAndroidSdkLink.set(false)
+            outputDirectory.set(file("docs"))
+        }
+    }
+}
+android {
+    compileSdkVersion 30
+
+    defaultConfig {
+        minSdkVersion 21
+        targetSdkVersion 30
+        versionCode 1
+        versionName version_name
+
+        testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
+
+    }
+    buildTypes {
+        release {
+            minifyEnabled false
+            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
+        }
+    }
+}
+
+repositories {
+    mavenCentral()
+}
+
+publishing {
+    publications {
+        aar(MavenPublication) {
+            groupId = 'com.chartiq'
+            artifactId 'chartiq'
+            version = version_name
+            artifact "${project.buildDir}/outputs/aar/chartiq-release.aar"
+
+            pom.withXml {
+                def root = asNode()
+                def license = root.appendNode('licenses').appendNode('license')
+                license.appendNode('name', 'MPL, Version 2.0')
+                license.appendNode('url', 'https://www.mozilla.org/en-US/MPL/2.0/')
+                license.appendNode('distribution', 'repo')
+            }
+        }
+    }
+}
+
+dependencies {
+    implementation fileTree(dir: 'libs', include: ['*.jar'])
+
+    implementation "androidx.appcompat:appcompat:1.2.0"
+    implementation "androidx.core:core-ktx:1.3.2"
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation "com.google.code.gson:gson:2.8.6"
+}

chartiq/docs/README.md

@@ -0,0 +1,5 @@
+### How to build documentation
+
+Documentation is built with Dokka using the `dokkaHtml` task. Configuration in chartiq/build.gradle.
+
+Documentation also includes chartiq styling, which is in chartiq/docs/chartiq.css. In order to apply that to the docs, copy the contents and add them to chartiq/docs/styles/main.css after running `dokkaHtml`.

chartiq/docs/chartiq.css

@@ -0,0 +1,51 @@
+#main {
+    margin-top: 68px;
+}
+
+#logo {
+    position: absolute;
+    top: 0;
+    left: 0;
+    margin: 0;
+    padding: 0;
+    height: 68px;
+    width: 100vw;
+    background-image: url(https://documentation.chartiq.com/img/CIQ_logo_full_negative.png);
+    background-color: #131d24;
+    background-size: 121px 45px;
+    background-position: 20px center;
+}
+
+#logo::after {
+    content: "Native Android SDK";
+    position: absolute;
+    left: 160px;
+    color: white;
+    font-size: 16px;
+    top: 24px;
+}
+
+#leftColumn {
+    border-right: 0px;
+    align-items: center;
+    margin-top: 68px;
+}
+
+#paneSearch {
+    display: flex;
+    width: calc(100% - 1px);
+    align-items: center;
+    justify-content: center;
+}
+
+.paneSearchInputWrapper {
+    width: 248px;
+}
+
+#paneSearch, #sideMenu {
+    border-right: 1px solid #DADFE6;
+}
+
+.platform-tag.jvm-like {
+    background-color: rgb(59, 114, 98);
+}