Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When manually reporting a post that has already been recently reported with a custom reason, add that reason to the original report as a comment #3712

Open
gparyani opened this issue Jan 7, 2020 · 5 comments
Labels
area: commands status: confirmed Confirmed as something that needs working on. type: feature request Shinies.

Comments

@gparyani
Copy link
Contributor

gparyani commented Jan 7, 2020

When manually reporting a post, there is an option to provide a custom reason why the post is being reported along with the report (#1965). Since #2398 was implemented, using this feature will also post a comment on the metasmoke page for the report with the same reason text, attributed to the reporter.

If I report a post using this feature and it's already been recently reported, the reason text will go into the void, on the other hand.

Can we please make it so that if someone supplies a custom reason on a manual report regarding a post that has already been recently reported, the reason they supply becomes another comment on the existing report?

@makyen
Copy link
Contributor

makyen commented Jan 7, 2020

While this certainly could be implemented, the chat response from SD should indicate to the user that the !!/report didn't actually create a report. They should then be able to manually add the comment to the existing post.

@gparyani
Copy link
Contributor Author

gparyani commented Jan 7, 2020

@makyen It does indicate so, with a link to the existing report. But it might confuse some users into thinking that their reason was placed on said earlier report. Making the comment automatic would be much nicer.

@stale
Copy link

stale bot commented Feb 8, 2020

This issue has been closed because it has had no recent activity. If this is still important, please add another comment and find someone with write permissions to reopen the issue. Thank you for your contributions.

@stale stale bot closed this as completed Feb 8, 2020
@makyen makyen added the status: confirmed Confirmed as something that needs working on. label Feb 8, 2020
@makyen makyen reopened this Feb 8, 2020
@stale stale bot removed the status: stale label Feb 8, 2020
user12986714 added a commit to user12986714/SmokeDetector that referenced this issue May 26, 2020
Refactored report related functionalities to reduce redundancy in code. Also implemented: issue Charcoal-SE#3712 and issue Charcoal-SE#2795 .
@makyen
Copy link
Contributor

makyen commented Jul 20, 2020

As far as I know this was resolved a month, or so, ago.

@makyen makyen closed this as completed Jul 20, 2020
@gparyani
Copy link
Contributor Author

@makyen This was never resolved. I just tested this and my reason wasn't added. If you're referring to the above PR resolving this, that's still open and not been merged yet.

@makyen makyen reopened this Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: commands status: confirmed Confirmed as something that needs working on. type: feature request Shinies.
Development

No branches or pull requests

2 participants