feat(runtime): change StrEnum stub type to StrEnum | str#71
Merged
Chaoses-Ib merged 2 commits intoChaoses-Ib:mainfrom Sep 23, 2024
Merged
feat(runtime): change StrEnum stub type to StrEnum | str#71Chaoses-Ib merged 2 commits intoChaoses-Ib:mainfrom
StrEnum | str#71Chaoses-Ib merged 2 commits intoChaoses-Ib:mainfrom
Conversation
Chaoses-Ib
reviewed
Sep 22, 2024
Co-authored-by: Chaoses-Ib <Chaos-es@outlook.com>
Chaoses-Ib
changed the title
StrEnum | str
This was referenced Jan 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
The rationale behind this change is to shut up my typechecker when I'm working with ComfyScript and I'm not able to generate stubs for all known files ahead of time. A good example is when working with Modal, as in
examples/modal.py.One downside to this change is that it also adds '| str' to the enums that are completely known ahead of time, like Samplers or Schedulers, since I wasn't sure how to differentiate them.
Before:
def __new__(cls, ckpt_name: Checkpoints) -> tuple[Model, Clip, Vae]: ...After:
def __new__(cls, ckpt_name: Checkpoints | str) -> tuple[Model, Clip, Vae]: ...