Set default python version 3.9 and fix strenum problem#135
Open
Set default python version 3.9 and fix strenum problem#135
Conversation
|
jacomago
requested review from
anderslindho,
ralphlange,
shroffk,
simon-ess and
tynanford
Contributor
Author
|
I tried to get this check in the pre-commit, but adding all ruff lints wasn't enough, I had to add type checking... Which made the PR huge. So I'll stick with just this change for now. |
anderslindho
reviewed
Feb 6, 2026
| hooks: | ||
| # Run the linter. | ||
| - id: ruff | ||
| args: [ --fix ] |
Contributor
There was a problem hiding this comment.
Don't think this is needed anymore, and the hook has been renamed (ruff-check IIRC)
| name="recceiver" | ||
| name = "recceiver" | ||
| version = "1.5" | ||
| description = "resync server" |
| [project.urls] | ||
| Repository="https://github.com/mdavidsaver/recsync" | ||
| optional-dependencies.test = [ "pytest", "testcontainers>=4" ] | ||
| urls.Repository = "https://github.com/mdavidsaver/recsync" |
Contributor
There was a problem hiding this comment.
I think this is wrong?
|
|
||
| [tool.ruff] | ||
| line-length = 120 | ||
| target-version = "py39" |
Contributor
There was a problem hiding this comment.
This doesn't mesh well with your attempt to externalise python version into a variable
|
|
||
| [tool.pytest.ini_options] | ||
| log_cli = true | ||
| log_cli_level = "DEBUG" |
Contributor
There was a problem hiding this comment.
Do we really need this as default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.