-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Version Number to Assembly #31
Apply Version Number to Assembly #31
Conversation
'ContinousDelivery' to GitVersion.yml
…oesn't accept the arg
…access to the gitversion var in the useConfigFile setup
…' from the gitversion output
Ok - I figured out how to correct the GitVersion.yml file, so It builds with it generating the version number information. I had to change the mode specification from 'Mainline' to 'ContinousDelivery'. 'Mainline' is not an accepted value for that. And in the pack command, I had to correct where to look up version number. So that all works, and I have a successful build. Also, I had to merge my branch target_fx_update, into this one. So, this PR should satisfy both
I had to do that, because I had already fixed the update the target fx versions. I was not able to verify the version numbers in the Common.Logging.Serilog.dll file, because this workflow does not seem to have any artifacts to download ? So, if you could check it or instruct me as to how I can check it, that would be great. Thank you! |
Hello,
I would like to submit this PR to address Issue #28. As described in the issue, it appears that the assembly versioning was dropped in the most recent builds. As such the libraries are defaulting to 1.0.0.0 for File Version and Assembly Version.
Please take a look at these changes and accept this PR. I must admit, I was not sure how to properly test this change. If there is a way to produce a test build, on Github for a PR, please send me the instructions and I will do so.
Otherwise, if you could advise what the proper changes should be, that would be great!
Cheers!