Relax the metadata pattern in validator.

PiperOrigin-RevId: 293763161
ChanchalKumarMaji · Feb 11, 2020 · 485783c · 485783c
1 parent 24e6ed6
commit 485783c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/...hub/workflows/contributions-validator.yml → ...hub/workflows/contributions-validator.yml b/...hub/workflows/contributions-validator.yml → ...hub/workflows/contributions-validator.yml
diff --git a/tfhub_dev/tools/validator.py b/tfhub_dev/tools/validator.py
@@ -59,7 +59,9 @@
     r"# Collection (?P<publisher>[\w-]+)/(?P<name>(\w|-|/|&|;|\.)+)/(\d+)")
 # Regex pattern for the line of the documentation describing model metadata.
 # Example: "<!-- finetunable: true -->"
-METADATA_LINE_PATTERN = r"^<!-- (?P<key>(\w|\s|-)+): (?P<value>.+) -->$"
+# Note: Both key and value consumes free space characters, but later on these
+# are stripped.
+METADATA_LINE_PATTERN = r"^<!--(?P<key>(\w|\s|-)+):(?P<value>.+)-->$"
 
 
 class Filesystem(object):
@@ -271,8 +273,9 @@ def consume_metadata(self):
       match = re.match(METADATA_LINE_PATTERN, self._lines[self._current_index])
       if match:
         # Add found metadata.
-        key = match.group(1)
-        value = match.group(3)
+        groups = match.groupdict()
+        key = groups.get("key").strip()
+        value = groups.get("value").strip()
         if key not in self._parsed_metadata:
           self._parsed_metadata[key] = set()
         self._parsed_metadata[key].add(value)

diff --git a/tfhub_dev/tools/validator_test.py b/tfhub_dev/tools/validator_test.py
@@ -45,8 +45,8 @@ def recursive_list_dir(self, root_dir):
 multiple lines.
 
 <!-- asset-path: %s -->
-<!-- module-type: text-embedding -->
-<!-- fine-tunable: true -->
+<!-- module-type:   text-embedding   -->
+<!-- fine-tunable:true -->
 <!-- format: saved_model_2 -->
 
 ## Overview