Fix to container.upload()'s behavior to match its doc #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JOUNAIDSoufiane
requested review from
Mark-Powers and
msherman64
as code owners
msherman64
reviewed
Feb 9, 2024
There was a problem hiding this comment.
So, I think this makes sense, but I'm not completely clear on the "before/after"
Could you add a quick example of how the invocation (from the user side) changes?
Tests would also be nice, but that seems like too big a lift to add to python-chi at the moment?
|
Regarding tests, yes I think we might need to set up a full proper test suite when rewriting python-chi. |
Mark-Powers
approved these changes
Feb 13, 2024
container.upload() previously only uploaded the contents of a specified directory path to the container. It now uploads the file or directory pointed to by the specified path. Example before: container.upload(test.png) would not upload the file as it would need a directory path. Example before: container.upload(test/) would upload the contents of the test directory Example after: container.upload(test.png) uploads the file test.png and container.upload(test/) uploads the entire test directory
JOUNAIDSoufiane
force-pushed
the
soufianej-container-upload-fix
branch
from
9166a01
to
9058388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container.upload() previously only packaged the contents of a directory to a tar archive and passes it as a byte stream to zun. This change is to make sure that container.upload() adds the specified source file or specified source directory to the tar archive as originally intended by its design.