-
Notifications
You must be signed in to change notification settings - Fork 1k
Conversation
Another great snippet. Couple suggestions:
Looks great other than that |
@atomiks Thanks for your comment. It's a good point. I have added transition for label's background color and the knob. And I pick the color #7983ff, if you have any suggestion, please let me know. |
One thing I noticed, and it's extremely subtle, but the knob has tiny 1px jerks as it finishes the transition because it's translating I think you can do this: input[type="checkbox"]:checked+.switch::after {
left: 0;
transform: translateX(21px);
/* remove margin-left: -1px */
} Edit: it also may not be accessible? .offscreen {
/* remove display: none; */
position: absolute;
left: -9999px;
} |
@atomiks Thanks! That's good suggestion. I agree that use transform will help animation and is more smooth than use left property. Also yeah, the your change for One thing is the |
With I've made some improvements and I think it's ready now 👍 |
Looks good to me. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recent changes make it smoother. nice
@atomiks Any more comment? Just wonder when will it merge to master branch if everything looks good? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks. |
No description provided.