Skip to content

Commit

Permalink
Update version string for v2.2.0 final release
Browse files Browse the repository at this point in the history
Update documentation and contribution guidelines
Remove declaration of WRITE_EXTERNAL_STORAGE permission completely (was previously declared for API level <= 18)
  • Loading branch information
codinguser committed May 3, 2017
1 parent d6310a6 commit 65e3fbc
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 14 deletions.
12 changes: 9 additions & 3 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
GnuCash Android is built by people like you! Please [join us](https://github.com/codinguser/gnucash-android).

## Git and Pull requests
## Reporting Issues
* The GitHub issue tracker is used for collecting and managing bugs, feature requests and general development planning.
* When creating a request, first search to make sure a similar one doesn't already exist in the tracker.
* Be as specific as possible when providing descriptions of the problems encountered and what the expected behaviour should be.
* It is also possible to report issues by creating tickets directly from within the app (in the Help Center)

## Code Contributions
* Contributions are submitted, reviewed, and accepted using Github pull requests. [Read this article](https://help.github.com/articles/using-pull-requests) for some details. We use the _Fork and Pull_ model, as described there.
* You can maintain your stable installation of GnuCash and test with another installation.
The two instances of GnuCash Android will live side-by-side on your device and not affect each other. You can install the development version by executing `gradle installDD` inside the root project directory
Expand All @@ -18,8 +24,8 @@ The two instances of GnuCash Android will live side-by-side on your device and n
* Try to make clean commits that are easily readable (including descriptive commit messages!)
* Test before you push make sure all test pass on your machine.
* Unit tests can be run with `gradle test`
* UI tests can be run with `gradle cDDAT`
* Make small pull requests that are easy to review but make sure they do add value by themselves.
* UI tests can be run with `gradle spoonDD`. This will run the tests on all connected devices/emulators.
* Make small pull requests that are easy to review but which also add value.

## Coding style
* Do write comments. You don't have to comment every line, but if you come up with something thats a bit complex/weird, just leave a comment. Bear in mind that you will probably leave the project at some point and that other people will read your code. Undocumented huge amounts of code are nearly worthless!
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Change Log
===============================================================================
Version 2.2.0 *(2017-05-xx)*
Version 2.2.0 *(2017-05-05)*
----------------------------
* Feature #646: Option to select backup file using Storage Access Framework
* Feature #565: Regular automatic backups (even when not explicitly set by user)
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ Google+ Community: https://plus.google.com/communities/104728406764752407046

There are several ways you could contribute to the development.

* Pull requests are always welcome! You could contribute code by fixing bugs, adding new features or automated tests.
Take a look at the [bug tracker](https://github.com/codinguser/gnucash-android/issues?state=open)
for ideas where to start. Also make sure to read our [contribution guidlines](https://github.com/codinguser/gnucash-android/blob/master/.github/CONTRIBUTING.md)

* One way is providing translations for locales which are not yet available, or improving translations.
Please visit [CrowdIn](https://crowdin.com/project/gnucash-android) in order to update and create new translations

* You could as well contribute code, fixing bugs, new features or automated tests. Pull requests are always welcome.
Take a look at the [bug tracker](https://github.com/codinguser/gnucash-android/issues?state=open)
for ideas where to start. Also take a look at the [contribution guidlines](https://github.com/codinguser/gnucash-android/blob/master/.github/CONTRIBUTING.md)

For development, it is recommended to use the Android Studio for development which is available for free.
Import the project into the IDE using the build.gradle file. The IDE will resolve dependencies automatically.

Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ apply plugin: 'android-apt'
def versionMajor = 2
def versionMinor = 2
def versionPatch = 0
def versionBuild = 3
def versionBuild = 4

def buildTime() {
def df = new SimpleDateFormat("yyyyMMdd HH:mm 'UTC'")
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@
<uses-permission android:label="@string/label_permission_create_accounts"
android:name="org.gnucash.android.permission.CREATE_ACCOUNT" />

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"
android:maxSdkVersion="18" />
<uses-permission android:name="android.permission.VIBRATE"
android:label="Allow device to vibrate with notifications" />
<uses-permission android:name="android.permission.WAKE_LOCK" />
Expand Down
5 changes: 2 additions & 3 deletions play_store_description.txt
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ You can also import an existing account hierarchy from GnuCash desktop.

<br/><small>
<i><u>What does the app use the requested permissions for? </u></i>
&bull; READ_EXTERNAL_STORAGE: Used to export transactions/accounts to the SD card
&bull; RECEIVE_BOOT_COMPLETED: Used to restart service for scheduled transactions or exports after device is rebooted
&bull; VIBRATE: Used to provide haptic feedback when entering some inputs
&bull; WAKE_LOCK: Used for keeping device active when exporting scheduled transactions in the background service
&bull; INTERNET/ACCESS_NETWORK_STATE: Used when exporting accounts/transactions to 3rd-party service like Google Drive or DropBox
&bull; RECEIVE_BOOT_COMPLETED: Used to restart service for scheduled transactions or exports after device is rebooted
&bull; INTERNET/ACCESS_NETWORK_STATE: Used when exporting accounts/transactions to 3rd-party service like DropBox or ownCloud
</small>

0 comments on commit 65e3fbc

Please sign in to comment.