-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: move frontend out of poetry scope #309
Conversation
Yes, nice! I'd personally remove the |
That's more clear, the changes has been commited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an additional change is required on this line. The readme is supposed to be copied to the chainlit python dir (for pypi and other stuff).
Also the latest release introduced conflicts it seems.
Good work!
Thanks for your remind, all the issues has been fixed. |
Ill try this branch on my laptop before merging, since it has the potential to break a lot of things :) |
Thank you for your contribution! We ended up merging #343 which was inspired by your work! Closing this one :) |
After a new release publish, I think it's a good time to move frontend out of the poetry scope to speed up the build time.
Close #276