Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move frontend out of poetry scope #309

Closed
wants to merge 18 commits into from

Conversation

chenjuneking
Copy link
Contributor

After a new release publish, I think it's a good time to move frontend out of the poetry scope to speed up the build time.

Close #276

@ramnes
Copy link
Contributor

ramnes commented Aug 22, 2023

Yes, nice! I'd personally remove the src/ folder because it adds a level for not much (although that's controversial) and also rename chainlit/chainlit/ to backend/chainlit/ so that it's clear that it's the backend code.

@chenjuneking
Copy link
Contributor Author

Yes, nice! I'd personally remove the src/ folder because it adds a level for not much (although that's controversial) and also rename chainlit/chainlit/ to backend/chainlit/ so that it's clear that it's the backend code.

That's more clear, the changes has been commited.

Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an additional change is required on this line. The readme is supposed to be copied to the chainlit python dir (for pypi and other stuff).

Also the latest release introduced conflicts it seems.

Good work!

@chenjuneking
Copy link
Contributor Author

I think an additional change is required on this line. The readme is supposed to be copied to the chainlit python dir (for pypi and other stuff).

Also the latest release introduced conflicts it seems.

Good work!

Thanks for your remind, all the issues has been fixed.

@willydouhard
Copy link
Collaborator

Ill try this branch on my laptop before merging, since it has the potential to break a lot of things :)

@ramnes ramnes changed the title feat: move fronend out of the poetry scope feat: move frontend out of poetry scope Aug 23, 2023
@willydouhard
Copy link
Collaborator

Thank you for your contribution! We ended up merging #343 which was inspired by your work! Closing this one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speed up the building time?
3 participants