feat (#1858), Implement settings change listener. #2801
Open
FosanzDev wants to merge 1 commit intoChainlit:mainfrom
Open
feat (#1858), Implement settings change listener. #2801FosanzDev wants to merge 1 commit intoChainlit:mainfrom
FosanzDev wants to merge 1 commit intoChainlit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="backend/chainlit/__init__.py">
<violation number="1" location="backend/chainlit/__init__.py:86">
P2: New callback is imported but missing from __all__, so it won’t be exposed in the package’s public API list or wildcard imports like other callbacks.</violation>
</file>
<file name="libs/react-client/src/useChatInteract.ts">
<violation number="1" location="libs/react-client/src/useChatInteract.ts:135">
P2: editChatSettings is defined but never returned from useChatInteract, so consumers cannot invoke the new chat_settings_edit socket event.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This way you can read what changed and return a new set of settings dinamically.
Collaborator
|
Re-running failed E2E tests. If they keep failing, means there's a problem! |
hayescode
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT DOES THIS DO?
It basically adds a new listener for when the settings change in the frontend, not just when they're updated. This way you can resend a new set of settings to the frontend to render.
EDIT: Changed naming from on_chat_settings_edit > on_settings_edit for the sake of readability on a forced push.
Code example:
POC (in my case, multi-language bible version selection for a personal project)
Screencast.from.2026-02-22.17-04-22.webm
Note: There might be some changes in the code linting bc of my IDE settings
Summary by cubic
Adds a live chat settings edit listener so the app can react to on-the-fly changes and push updated widgets back to the UI. Implements the settings change listener requested in Linear #1858.
Written for commit 912ed3d. Summary will update on new commits.