fix: initialize user_can_view before conditional block#2776
Closed
thecaptain789 wants to merge 1 commit intoChainlit:mainfrom
Closed
fix: initialize user_can_view before conditional block#2776thecaptain789 wants to merge 1 commit intoChainlit:mainfrom
thecaptain789 wants to merge 1 commit intoChainlit:mainfrom
Conversation
thecaptain789
requested review from
asvishnyakov,
hayescode and
sandangel
as code owners
dosubot
bot
added
size:XS
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
This PR is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
Collaborator
|
Dup of #2775 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2766
When
@cl.on_shared_thread_viewhook is not defined,user_can_viewwas never initialized, causing anUnboundLocalErrorwhen the variable was referenced.This initializes
user_can_view = Falsebefore the conditional block to provide a safe default.Summary by cubic
Initialize user_can_view = False in get_shared_thread to avoid UnboundLocalError when on_shared_thread_view isn’t defined.
Written for commit f145ceb. Summary will update on new commits.