Skip to content

fix: propagate IME composition events in AutoResizeTextarea #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: propagate IME composition events in AutoResizeTextarea #2575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions frontend/src/components/AutoResizeTextarea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ interface Props extends Omit<React.ComponentProps<'textarea'>, 'onPaste'> {
placeholder?: string;
onPaste?: (event: ClipboardEvent) => void;
onEnter?: (event: React.KeyboardEvent<HTMLTextAreaElement>) => void;
onCompositionStart?: (
event: React.CompositionEvent<HTMLTextAreaElement>
) => void;
onCompositionEnd?: (
event: React.CompositionEvent<HTMLTextAreaElement>
) => void;
}

const AutoResizeTextarea = ({
Expand All @@ -17,6 +23,8 @@ const AutoResizeTextarea = ({
placeholder,
className,
onKeyDown,
onCompositionStart,
onCompositionEnd,
...props
}: Props) => {
const textareaRef = useRef<HTMLTextAreaElement>(null);
Expand Down Expand Up @@ -60,13 +68,31 @@ const AutoResizeTextarea = ({
}
};

const handleCompositionStart = (
event: React.CompositionEvent<HTMLTextAreaElement>
) => {
setIsComposing(true);
if (onCompositionStart) {
onCompositionStart(event);
}
};

const handleCompositionEnd = (
event: React.CompositionEvent<HTMLTextAreaElement>
) => {
setIsComposing(false);
if (onCompositionEnd) {
onCompositionEnd(event);
}
};

return (
<Textarea
ref={textareaRef as any}
{...props}
onKeyDown={handleKeyDown}
onCompositionStart={() => setIsComposing(true)}
onCompositionEnd={() => setIsComposing(false)}
onCompositionStart={handleCompositionStart}
onCompositionEnd={handleCompositionEnd}
className={cn(
'p-0 min-h-[40px] h-[40px] rounded-none resize-none border-none overflow-y-auto shadow-none focus:ring-0 focus:ring-offset-0 focus-visible:ring-0 focus-visible:ring-offset-0',
className
Expand Down
Loading