Skip to content

Chainlit Data Layer - preserve metadata in update_thread() #2538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Chainlit Data Layer - preserve metadata in update_thread() #2538

wants to merge 1 commit into from

Conversation

DmitriyAlergant
Copy link
Contributor

No description provided.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. backend Pertains to the Python backend. data layer Pertains to data layers. labels Sep 22, 2025
This was referenced Sep 22, 2025
Open
Open
@DmitriyAlergant
Copy link
Contributor Author

I'll take a look at the failed test, a contract has changed after the test was written, I think I missed that commit to fix the test.

E2E tests failed not at my fault - may need to restart later

Downloading uv from "https://github.com/astral-sh/uv/releases/download/0.8.19/uv-x86_64-unknown-linux-gnu.tar.gz" ...
read ECONNRESET
Waiting 10 seconds before trying again
read ECONNRESET
Waiting 20 seconds before trying again
Error: read ECONNRESET

@DmitriyAlergant DmitriyAlergant mentioned this pull request Sep 22, 2025
Open
@akotlar
Copy link

akotlar commented Oct 5, 2025

thank you for making this!

@DmitriyAlergant
Copy link
Contributor Author

DmitriyAlergant commented Oct 5, 2025 •
edited
Loading

@akotlar sorry I never got a chance to properly finish this PR (tests, etc). While eventually i think I fixed it in our fork, this change got intermingled with other things we needed to fix and at this time I don't have a clean atomic PR for this fix only which would have passed CI. The original change still works though, but tests need to be fixed.

@akotlar
Copy link

akotlar commented Oct 5, 2025

No man don't apologize, this was great. It helped me resolve an issue that I was having, and for that I'm grateful. I don't care about the tests, I can fix those :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hayescode hayescode Awaiting requested review from hayescode hayescode is a code owner

@asvishnyakov asvishnyakov Awaiting requested review from asvishnyakov asvishnyakov is a code owner

@sandangel sandangel Awaiting requested review from sandangel sandangel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backend Pertains to the Python backend. data layer Pertains to data layers. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DmitriyAlergant @akotlar