Skip to content

Conversation

xjose97x
Copy link
Contributor

This should fix: #2376

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. frontend Pertains to the frontend. labels Aug 12, 2025
Copy link
Member

@asvishnyakov asvishnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xjose97x Thank you for the contribution! Nice catch! However

  1. e2e tests doesn't test all conditions specified in #2393
  2. cy.wait proven to cause issues and worse e2e tests stability. Please try to wait for something else - I believe simple reordering (check text / length first) should work

@xjose97x
Copy link
Contributor Author

@xjose97x Thank you for the contribution! Nice catch! However

  1. e2e tests doesn't test all conditions specified in Rewrite chat input to use textarea and ChatGPT-style command selection (fixes inline command bugs) #2393
  2. cy.wait proven to cause issues and worse e2e tests stability. Please try to wait for something else - I believe simple reordering (check text / length first) should work

Thanks @asvishnyakov .
Just added to test also Step (previously I was only testing Message).
Am I missing other conditions? Sorry I looked at that PR but not sure what conditions you are referring to.

I also removed cy.wait and now I'm just using timeouts.

@xjose97x xjose97x requested a review from asvishnyakov August 12, 2025 16:10
@hayescode hayescode added this pull request to the merge queue Aug 13, 2025
Merged via the queue into Chainlit:main with commit c19f05d Aug 13, 2025
9 checks passed
@xjose97x xjose97x deleted the feat/blinking_cursor_activity branch August 13, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Pertains to the frontend. size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulsating dot that indicates activity does not show up

3 participants