Willy/sidebar #1779
Willy/sidebar #1779
Conversation
dosubot
bot
added
size:XL
dokterbob
left a comment
dokterbob
left a comment
There was a problem hiding this comment.
Please provide a link to documentation PR describing the feature, so I have some spec to evaluate it against. :)
Also see other comments, mostly to add a bit of docstrings explaining what's going on.
| threadId: Optional[str] | ||
| type: ElementType | ||
| chainlitKey: Optional[str] | ||
| path: Optional[str] |
There was a problem hiding this comment.
What does path here mean?
Having comments here on the meaning of these fields would improve developer experience.
There was a problem hiding this comment.
path is the local path of the element, a developer can load an image from path or url for instance.
There was a problem hiding this comment.
Great, having that in a comment would help other devs!
backend/chainlit/element.py
Outdated
| chainlit_key=_dict.get("id"), | ||
| display="inline", | ||
| mime=type, | ||
| def from_dict(cls, _dict: ElementDict): |
There was a problem hiding this comment.
Normally, _-prefixed variables signify private scope. Hence, I would recommend using a semantic name (to prevent using reserved dict). Something like e_dict?
backend/chainlit/element.py
Outdated
|
|
||
| # Image handling (excluding SVG which is treated as a file) | ||
| if type == "image" and "svg" not in mime_type: | ||
| return Image(size="medium", **common_params) # type: ignore |
There was a problem hiding this comment.
Why ignore typing here?
In case we ignore the type checker, I think:
- We should have a good reason for it.
- We should add a comment describing the reason.
There was a problem hiding this comment.
mypy is not happy with the ** decomposition in the class instantiation
There was a problem hiding this comment.
That's probably because common_params isn't typed. Or, actually, a bit of a loss on the side of mypy.
|
This PR doesn't included in the |
|
Still not fixed in the |
* wip * feat: controllable sidebar * fix: ruff * fix: copilot sidebar * fix: comments * fix: ruff
No description provided.