Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add translation on feedback #1701

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

mame7777
Copy link
Contributor

This pull request includes updates to the feedback functionality and translations across multiple languages. The most important changes include adding new feedback button texts and dialog messages, and updating the FeedbackButtons component to use the Translator component for internationalization.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. frontend Pertains to the frontend. labels Jan 14, 2025
@dokterbob dokterbob added the translation Translation or localisation of strings. label Jan 15, 2025
Copy link
Collaborator

@willydouhard willydouhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@mame7777
Copy link
Contributor Author

Thank you for review!

@willydouhard willydouhard merged commit 9470c87 into Chainlit:main Jan 16, 2025
9 checks passed
@mame7777 mame7777 deleted the feat/add-translation-on-feedback branch January 16, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Pertains to the frontend. size:L This PR changes 100-499 lines, ignoring generated files. translation Translation or localisation of strings.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants