Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/snapshot-eip-4881 #377

Closed
wants to merge 2 commits into from
Closed

Conversation

AkshatGada
Copy link

Attempts to solve issue ChainSafe/lodestar#4935

  1. Added deposit contract snapshot interface
  2. Added test cases

waiting for your review

@AkshatGada AkshatGada requested a review from a team as a code owner June 10, 2024 11:34
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@philknows
Copy link
Member

If you were trying to commit your work from here, it did not make it into this PR...

Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. A few comments:

Instead of redefining MerkleTree, Leaf, Node, etc here, please reuse the existing infra from this library. That means using the existing Tree, LeafNode, BranchNode constructs. You should be able to define your custom tree editing / navigation functions either purely functionally, or in a wrapper class.

Eventually, this code / PR should be migrated to the lodestar repo and live there. Whether you want to keep this review here for now is up to you.

@AkshatGada
Copy link
Author

AkshatGada commented Jun 14, 2024 via email

@philknows
Copy link
Member

Hi @AkshatGada , do you still plan to keep working on this?

@AkshatGada
Copy link
Author

Yes , I am a little busy with college and my internship , I am running tests locally , please grant me some time to get it done .

@AkshatGada
Copy link
Author

I am planning to do it as a project for the ethereum protocol fellowship.

@twoeths twoeths mentioned this pull request Sep 9, 2024
1 task
@philknows
Copy link
Member

Superseded by #400

@philknows philknows closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants