Add composite type leaves to proof #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a proof with a path to a composite type, include all leaves of the type in the proof.
|
This pull request introduces 1 alert when merging b89df8b into 8c31f3e - view on LGTM.com new alerts:
|
dapplion
reviewed
May 19, 2021
src/types/composite/list.ts
Outdated
| } | ||
| const gindices = super.tree_getLeafGindices(target, root); | ||
| // include the length chunk | ||
| gindices.push(concatGindices([root, BigInt(3)])); |
There was a problem hiding this comment.
Why 3 here? Could you add a comment explaining
There was a problem hiding this comment.
The comment on the line above is an attempt to explain 😅 open to any suggestions to make it clearer
dapplion
reviewed
May 19, 2021
| } | ||
| } else { | ||
| for (let i = 0, gindex = extendedStartIndex; i < chunkCount; i++, gindex++) { | ||
| gindices.push(...this.elementType.tree_getLeafGindices(undefined, gindex)); |
There was a problem hiding this comment.
dapplion
approved these changes
May 19, 2021
|
This pull request introduces 1 alert when merging a8546a0 into 8c31f3e - view on LGTM.com new alerts:
|
dapplion
reviewed
May 19, 2021
dapplion
approved these changes
May 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a proof with a path to a composite type, include all
leaves of the type in the proof.
CompositeType#tree_getLeafGindices(tree?: Tree, root?: Gindex): Gindex[]state.validators)CompositeType#createProofis extended to calltree_getLeafGindiceswhen the type at a path is a composite type.