Update ETH2 terminology to EthereumConsensus #59
Conversation
package.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "name": "eth2-crawler-ui", | |||
| "name": "ethereum-consensus-crawler-ui", | |||
There was a problem hiding this comment.
I'm imagining it's okay to change the package name since this isn't published to NPM
There was a problem hiding this comment.
I would keep it consistent with the renaming of eth2-crawler to nodewatch-api by changing this to nodewatch-crawler-api.
| @@ -22,16 +22,16 @@ const useStyles = makeStyles(() => { | |||
| function App() { | |||
| const classes = useStyles() | |||
| return ( | |||
| <ThemeSwitcher storageKey="eth2.themeKey" themes={{ light: theme }}> | |||
There was a problem hiding this comment.
I'm not sure if changing this is okay, but I couldn't find any reference/use of eth2.themeKey
There was a problem hiding this comment.
Yes, its ok, The themeswitcher uses this string to save current theme in localstorage.
|
If I'm reading this correctly, our "node count" is basically a combination of eth1 (Execution nodes) + eth2 (Consensus nodes)? It feels kind of misleading to combine the two together into "node count" as it could artificially double the real count of nodes on the network. It would be better IMO to keep these separate and display the data as two different metrics. |
@philknows Yes, I think this is correct. It would also appear that this |
Points of Discussion:
I'm not sure what to do about the mentioned ofeth1andeth2in this fileeth1andeth2toEthereum ExecutionandEthereum Consensus