refactor: add msFromSlot to validator clock

[nflaig]

This makes it easier to reason about the code

[gemini-code-assist]

Summary of Changes

Hello @nflaig, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors how time-based delays and cutoff times are calculated within the validator services. By introducing a new msFromSlot utility, the PR aims to simplify the logic for determining remaining time within a slot, making the codebase more intuitive and maintainable for future development and debugging.

Highlights

• New msFromSlot Function: Introduced a new msFromSlot method to the IClock interface and Clock class, which calculates the milliseconds elapsed since the beginning of a given slot.
• Refactored Time Calculations: Updated time-related calculations in AttestationService and SyncCommitteeService to utilize the newly added msFromSlot function. This refactors expressions like this.clock.msToSlot(slot) + duration to duration - this.clock.msFromSlot(slot), aiming for improved clarity and easier reasoning about the code.
• Clock Utility Consistency: Modified timeUntilNext and getCurrentSlotAround utility functions within clock.ts to consistently use config.SLOT_DURATION_MS instead of config.SECONDS_PER_SLOT * 1000 for slot duration calculations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a msFromSlot method to the validator clock and refactors its usage throughout the codebase. The new method improves the readability of time-based calculations. The changes are logically sound and consistently applied. I've added one suggestion to further enhance maintainability. Overall, this is a solid refactoring.

[nflaig]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new msFromSlot method to the Clock utility, which simplifies calculating time durations relative to a slot's start. This refactoring improves code readability in AttestationService and SyncCommitteeService. The logic is sound and the changes are applied consistently. I have one suggestion to improve maintainability by reducing code duplication in the new method's implementation.

[codecov]

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.26%. Comparing base (a3fd1d7) to head (6ba8a60).
⚠️ Report is 3 commits behind head on nc/timing-refactor.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           nc/timing-refactor    #8463   +/-   ##
===================================================
  Coverage               52.25%   52.26%           
===================================================
  Files                     853      853           
  Lines                   64963    64985   +22     
  Branches                 4762     4769    +7     
===================================================
+ Hits                    33947    33962   +15     
- Misses                  30947    30954    +7     
  Partials                   69       69           

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.