feat: log when publishing to 0 data column peers#8195
Merged
wemeetagain merged 4 commits intounstablefrom Aug 13, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## unstable #8195 +/- ##
=========================================
Coverage 54.22% 54.23%
=========================================
Files 843 844 +1
Lines 63402 63481 +79
Branches 4796 4796
=========================================
+ Hits 34381 34428 +47
- Misses 28946 28978 +32
Partials 75 75 🚀 New features to boost your workflow:
|
nflaig
reviewed
Aug 13, 2025
| } | ||
| } | ||
| if (columnsPublishedWithZeroPeers > 0) { | ||
| chain.logger.warn("Published data columns with 0 peers, increased risk of reorg", { |
Member
There was a problem hiding this comment.
would like to have at least slot and blockRoot in context
Contributor
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
nflaig
reviewed
Aug 13, 2025
nflaig
approved these changes
Aug 13, 2025
Member
Author
|
🎉 This PR is included in v1.34.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description