fix: peerDAS - missing file extensions in networkConfig#7693
fix: peerDAS - missing file extensions in networkConfig#7693dguenther wants to merge 1 commit intoChainSafe:peerDASfrom
Conversation
| @@ -1,6 +1,6 @@ | |||
| import {BeaconConfig} from "@lodestar/config"; | |||
| import {NodeId, computeNodeId} from "./subnets"; | |||
| import {CustodyConfig, computeCustodyConfig} from "../util/dataColumns"; | |||
There was a problem hiding this comment.
I am surprised our linter doesn't catch this
There was a problem hiding this comment.
we do have https://biomejs.dev/linter/rules/use-import-extensions/ though, not sure how this didn't catch the case here
There was a problem hiding this comment.
yes we should have catch this during our linting process, otherwise we'll have similar issues in the future
There was a problem hiding this comment.
it's seems the linter catches this though? I haven't tested the specific case but did a quick sanity check on unstable and it's complains about missing file extension there
There was a problem hiding this comment.
They're caught, but lints/tests aren't passing on the root peerDAS branch right now, so not all the errors are fixed there.
|
sorry @dguenther I didn't notice this PR exists so created #7694, was a bit rush to get lodestar work on devnet-6 |
|
Np, closing |
3 participants
Motivation
The Docker build isn't working on
peerDASbecause of missing file extensions -- this PR adds them in.Description
.jsfile extensions to imports innetworkConfig.ts