feat: use 16-bit random value to compute validator indices #7301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devnet-5 #7301 +/- ##
============================================
- Coverage 48.65% 48.63% -0.02%
============================================
Files 603 603
Lines 40427 40436 +9
Branches 2065 2067 +2
============================================
- Hits 19670 19667 -3
- Misses 20719 20731 +12
Partials 38 38 |
nflaig
reviewed
Dec 15, 2024
ensi321
force-pushed
the
nc/straighten-proposer-likelihood
branch
from
86ca960 to
aff569d
Compare
|
@ensi321 could you separate into 2 PRs: 1 for the main change and 1 for refactoring? |
ensi321
force-pushed
the
nc/straighten-proposer-likelihood
branch
from
aff569d to
169844e
Compare
|
Closing in favour of #7311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Electra spec, the likelihood vs effective balance graph represents a step function instead of linear for calculating proposer validator index and sync committee indices. eg. Two validators with one having 33ETH and the other having 40ETH will have the same probability of being elected as proposer because 33 and 40ETH are in the same "bucket" due to existed 8-bit random byte is not granular enough.
Changes random byte from 8-bit to 16-bit with restore the graph to linear.
Relevant spec: ethereum/consensus-specs#4039