chore: clean up single-used functions in Electra #7132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nc/devnet-4 #7132 +/- ##
===============================================
- Coverage 49.11% 49.01% -0.11%
===============================================
Files 598 596 -2
Lines 39879 39790 -89
Branches 2087 2059 -28
===============================================
- Hits 19588 19502 -86
+ Misses 20250 20247 -3
Partials 41 41 |
Ready for review now |
ensi321
force-pushed
the
nc/spec-cleanup
branch
from
03a2ec7
to
eb51e29
Compare
ensi321
force-pushed
the
nc/spec-cleanup
branch
from
eb51e29
to
a37f85f
Compare
nflaig
reviewed
Oct 11, 2024
| pubkey: validator.pubkey, | ||
| withdrawalCredentials: validator.withdrawalCredentials, | ||
| amount: balance, | ||
| signature: new Uint8Array(G2_POINT_AT_INFINITY), |
There was a problem hiding this comment.
this seems like an unnecessary conversion
we should probably convert everything to Uint8Array here as well
https://github.com/ChainSafe/lodestar/blob/unstable/packages/state-transition/src/constants/constants.ts#L1
nflaig
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.5.0-alpha.7includes several clean ups on the specs. Majority of them are removing definitions of single-used functions.Remove:
getActiveBalancequeueEntireBalanceAndResetValidatorgetMaxEffectiveBalanceupgradeStateToElectraOriginalWaiting for alpha 7 feature PRs to be merged.