fix: use toRootHex where applicable #7021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7021 +/- ##
=========================================
Coverage 49.24% 49.24%
=========================================
Files 578 578
Lines 37438 37443 +5
Branches 2162 2168 +6
=========================================
+ Hits 18435 18440 +5
Misses 18963 18963
Partials 40 40 |
twoeths
commented
Aug 14, 2024
packages/utils/src/bytes.ts
Outdated
|
|
||
| // this is to compliant to toHex() or toHexString() behavior | ||
| // in case unit tests, or consumers pass in a Uint8Array that is not 32 bytes accidentally | ||
| return toHex(root); |
There was a problem hiding this comment.
@wemeetagain @nflaig I want to make it compliant to the old apis so we don't have to worry about the wrong usage
There was a problem hiding this comment.
Are we calling this in any unit tests? since performance is not relevant there we might be fine with just throwing an error if byte length is invalid. So either the test values have to be adapted or can use toHex there instead
There was a problem hiding this comment.
agree to throw error here if it's not 32
my other thought is should we append "0x" here? we mostly use it for internal track and log
the down side with appending "0x" is almost 40% more memory allocation
There was a problem hiding this comment.
don't we have toMemoryEfficientHexStr for that?
I would like to have hex values prefixed with 0x in logs and we also use this on the api which needs 0x-prefix on all hex strings.
There was a problem hiding this comment.
ok then let's just keep 0x
There was a problem hiding this comment.
aren't most / all of these hex strings transient anyways?
nflaig
previously approved these changes
Aug 14, 2024
|
not ready until unit test is fixed see #7025 |
should be fixed |
nflaig
approved these changes
Aug 14, 2024
philknows
pushed a commit
that referenced
this pull request
Sep 3, 2024
* fix: use toRootHex where applicable * fix: toRootHex() to handle different lengths * fix: throw error if root is not 32 bytes * Fix eth1MergeBlockTracker unit test --------- Co-authored-by: Nico Flaig <nflaig@protonmail.com>
|
🎉 This PR is included in v1.22.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
toHex()and replace bytoRootHex()(previously I missed them because I only searched fortoHexString())lodestar/packages/types/src/bellatrix/sszTypes.ts
Line 54 in 44b2156
toRootHex()compliant to the old apis